phpvms/phpvms
phpvms/phpvms
1
0
Fork 0
Code Issues Pull Requests 1 Actions 1 Packages Releases Activity

Fix Metar Decoding / Wind check for Wind Chill (#1072)

Browse Source 
* Fix Metar Decoding / Wind check for Wind Chill

PR aims to fix the bug #1071 by checking both the wind speed and it's value for starting Wind Chill calculation.
This commit is contained in:
B.Fatih KOZ 2021-03-15 17:41:05 +03:00 committed by GitHub
parent b9e7a2efc9
commit e45bd66388
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Support/Metar.php
View File

@ -1772,7 +1772,7 @@ class Metar implements \ArrayAccess
*/ */
private function calculate_wind_chill($temperature_f): void private function calculate_wind_chill($temperature_f): void
{ {
if ($temperature_f < 51 && $this->result['wind_speed'] !== 0) { if ($temperature_f < 51 && $this->result['wind_speed'] && $this->result['wind_speed'] !== 0) {
$windspeed = $this->result['wind_speed']->toUnit('mph'); $windspeed = $this->result['wind_speed']->toUnit('mph');
if ($windspeed > 3) { if ($windspeed > 3) {
$chill_f = 35.74 + 0.6215 * $temperature_f - 35.75 * ($windspeed ** 0.16); $chill_f = 35.74 + 0.6215 * $temperature_f - 35.75 * ($windspeed ** 0.16);

13
tests/MetarTest.php
View File

@ -151,6 +151,19 @@ class MetarTest extends TestCase
$this->assertEquals('Few at 1500 feet; few at 25000 feet', $metar['clouds_report_ft']); $this->assertEquals('Few at 1500 feet; few at 25000 feet', $metar['clouds_report_ft']);
} }
/**
* https://github.com/nabeelio/phpvms/issues/1071
*/
public function testMetarWindSpeedChill()
{
$metar = 'EKYT 091020Z /////KT CAVOK 02/M03 Q1019';
$metar = Metar::parse($metar);
$this->assertEquals('VFR', $metar['category']);
$this->assertNull($metar['wind_speed']);
$this->assertEquals(6.21, $metar['visibility']['mi']);
}
/** /**
* Visibility in KM not parsed * Visibility in KM not parsed
* *